feat: add TopFieldError interface to expose parent struct reflection#1421
Open
VDHewei wants to merge 3 commits intogo-playground:masterfrom
Open
feat: add TopFieldError interface to expose parent struct reflection#1421VDHewei wants to merge 3 commits intogo-playground:masterfrom
VDHewei wants to merge 3 commits intogo-playground:masterfrom
Conversation
# Conflicts: # .gitignore # validator.go
Author
|
example: MyStruct Struct {
Data1 string `json:"data1" validate:"required" msg:"{jsonTag} must be required"`
}
func WarpValidatorError(err error) error {
if err != nil {
var (
errMsg []string
validationErrors validator.ValidationErrors
)
if errors.As(err, &validationErrors) {
for _, fieldErr := range validationErrors {
if customMsg := getCustomTagMsg(fieldErr); customMsg != "" {
errMsg = append(errMsg, customMsg)
} else {
errMsg = append(errMsg, fieldErr.Error())
}
}
}
if len(errMsg) > 0 {
return fiber.NewError(fiber.StatusBadRequest, fmt.Sprintf("Parameter verification failed,%s", strings.Join(errMsg, ";")))
}
return err
}
return nil
}
func getCustomTagMsg(e error) string {
var x validator.TopFieldError
if !errors.As(e, &x) {
return e.Error()
} else {
var (
msg string
t = x.Top().Type()
)
// pointer type
if t.Kind() == reflect.Ptr {
t = t.Elem()
}
// slice type
if t.Kind() == reflect.Slice || t.Kind() == reflect.Array {
t = t.Elem()
}
name := x.Field()
field, found := t.FieldByName(name)
if !found {
fmt.Printf("Field `%s` not found, param=%s,ns=%s\n", name, x.Param(), x.StructNamespace())
return ""
}
if msg = field.Tag.Get("msg"); msg == "" {
return msg
}
msg = strings.ReplaceAll(msg, "{fieldTag}", x.Field())
msg = strings.ReplaceAll(msg, "{jsonTag}", splitAndGetFirst(field.Tag.Get("json"), ","))
return msg
}
}
func splitAndGetFirst(value, sep string) string {
if value == "" {
return ""
}
values := strings.Split(value, sep)
if len(values) >= 1 {
return values[0]
}
return ""
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add TopFieldError interface exposing parent struct reflectionDescription:
This PR introduces a new
TopFieldErrorinterface extendingFieldErrorwith:Top() reflect.Valuemethod to access parent struct reflectionKey Changes:
errors.gofieldErrorUse Case:
Rationale: Maintains validator flexibility while enabling deeper struct inspection capabilities.
(Let me know if you'd like to emphasize any specific technical aspect further.)
@go-playground/validator-maintainers