Add OS distribution, C/C++ compiler and linker version to benchmark results#124
Add OS distribution, C/C++ compiler and linker version to benchmark results#124Calinou wants to merge 1 commit intogodotengine:mainfrom
Conversation
…esults This information is now stored for new benchmarks. Note that it's calculated at run-time using the same compiler/linker as used in production, since this information isn't stored at compile-time in the binary.
Ivorforce
left a comment
There was a problem hiding this comment.
Given that the information how the binary is built is most available in the build script, I'd like to propose passing it to the engine somehow from there. It might be possible to ask SCons to hand this information out.
While it's less convenient, it's also more correct, since the .gd file doesn't really know how the engine that's currently running was built (unless we do add an API for it).
This is what godotengine/godot#98845 implements, but I don't know when it'll be merged. What I could do in the meantime is make |
|
Your second suggestion is what I meant (pass the information explicitly from |
Ivorforce
left a comment
There was a problem hiding this comment.
I'll leave it up to you. As mentioned, the scripts are highly tailored to the benchmarking server anyway, so as long as it's correct, it should be fine.
Code looks good to me.
This information is now stored for new benchmarks.
Note that it's calculated at run-time using the same compiler/linker as used in production, since this information isn't stored at compile-time in the binary. (godotengine/godot#98845 implements this feature.)
Currently, existing benchmarks will display
Linuxfor the OS and(unknown)for the compiler/linker. I could modify the existing result files to update the distro/compiler/linker information based on the run dates (to roughly match the latest Fedora version available at the time, as well as GCC/LD from its repositories). That said, doing so would be an approximation so it may be best to leave things as-is, especially since I don't remember the exact dates at which I upgraded the server.and closes OS reported in recent benchmarks does not match the OS info on the main page #113.
Preview