Make sure last LSP client is disconnected before creating a new one. #912
Open
jstraceski wants to merge 3 commits intogodotengine:masterfrom
Open
Make sure last LSP client is disconnected before creating a new one. #912jstraceski wants to merge 3 commits intogodotengine:masterfrom
jstraceski wants to merge 3 commits intogodotengine:masterfrom
Conversation
Member
|
Could you check whether your original issue was solved by #968 This PR looks alright as safeguard. But in concept |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LSP client seems to have left over resources when restarting godot.
This causes CTRL-hover to fail after restarting godot because multiple
textDocument/definitionrequests are sent.Steps to reproduce issue:
If you have a debuging window open you should see
rx/txsimilar to this:This change disconnects io functions, and stops the last valid LSP client before making a new client.
(I did test this on godot > 4.5 but I have made some local changes so there is a chance that it is not required under the current stable godot version.)