jsonpb friendly random Any wkt generation #602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and rather use a jsonpb friendly version. when you marshal with jsonpb it expects a registered proto message since it has to unmarshal it in order to format it in the 'any' json format. The new populated method just uses a random Duration wkt which is already in the same package.
jmarais
force-pushed
the
anyjsontestgeneration
branch
from
3caab00 to
f9065fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 'any' from generating a standard NewPopulated method and rather use a jsonpb friendly version. When you marshal with jsonpb it expects a registered proto message since it has to unmarshal it in order to format it in the 'any' json format. The new populated method just uses a random Duration wkt which is already in the same package.