fix: project view --id flag not working#639
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #639 +/- ##
=========================================
- Coverage 10.99% 7.18% -3.81%
=========================================
Files 173 260 +87
Lines 8671 12832 +4161
=========================================
- Hits 953 922 -31
- Misses 7612 11802 +4190
- Partials 106 108 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@bupd @NucleoFusion please review. |
qcserestipy
left a comment
There was a problem hiding this comment.
Thank you for your contribution! I added a few comments. It would make the code simpler by removing the CheckProject function and replace the logic where it is used with GetProject.
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
Signed-off-by: Sypher845 <suyashpatil845@gmail.com>
bad54ba to
4428927
Compare
|
@qcserestipy |
Fixes #638
This pull request updates how project existence checks are performed across several project-related commands, allowing the checks to distinguish between project names and project IDs. The main change is to the
CheckProjectfunction, which now accepts a flag to specify whether to check by project name or ID, and all relevant commands have been updated to use this new parameter.API changes:
CheckProjectfunction inproject_handler.goto accept auseProjectIDboolean parameter, enabling checks by either project name or project ID. The function now usesGetProjectwhen checking by ID and falls back to the original method when checking by name.Command updates:
logs,view,member create, andmember deletecommands to callCheckProjectwith the appropriateisIDflag, ensuring that project existence checks are accurate based on whether a name or ID is provided.viewcommand to also pass theisIDflag toGetProjectafter the existence check, ensuring the project is retrieved using the correct identifier type.