feat: Migrate Trivy.robot(Security Hub Testcase) to playwright ( With CI fix ) #22791
Conversation
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com> fix: playwright github action Signed-off-by: bupd <bupdprasanth@gmail.com> fix: playwright github action Signed-off-by: bupd <bupdprasanth@gmail.com> fix: rename login logout test Signed-off-by: bupd <bupdprasanth@gmail.com> fix: playwright testing Signed-off-by: bupd <bupdprasanth@gmail.com> feat: correct test Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: bupd <bupdprasanth@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
|
To the maintainers: @bupd @OrlinVasilev @MinerYang @stonezdj @Vad1mo During the community meeting, we discussed the failing CI for PR #22591, which is needed to validate the PoC for the Playwright migration. I identified the two issues causing the CI failures and have fixed them. To verify the changes, I’ll need to run the CI. If you could approve the CI run, that would be great. Please let me know if anything else is missing or needs improvement. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22791 +/- ##
==========================================
+ Coverage 45.36% 46.63% +1.26%
==========================================
Files 244 252 +8
Lines 13333 14287 +954
Branches 2719 2937 +218
==========================================
+ Hits 6049 6663 +614
- Misses 6983 7266 +283
- Partials 301 358 +57
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Perform the request (insecure curl -> we skip TLS validation) | ||
| // If you're using node-fetch or running in Node, set NODE_TLS_REJECT_UNAUTHORIZED=0 | ||
| process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0'; |
Check failure
Code scanning / CodeQL
Disabling certificate validation High test
| } | ||
|
|
||
| export function runCommand(command: string): string { | ||
| console.log(`\n$ ${command}`); |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High test
| console.log('✅ Command output:\n', output.trim()); // print captured output | ||
| return output.trim(); // return for further processing | ||
| } catch (error: any) { | ||
| console.error(`❌ Command failed: ${command}`); |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High test
| * Runs a shell command and returns the output | ||
| */ | ||
| function runCommand(command: string): string { | ||
| console.log(`\n$ ${command}`); |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High test
| console.log('Command output:\n', output.trim()); | ||
| return output.trim(); | ||
| } catch (error: any) { | ||
| console.error(`Command failed: ${command}`); |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High test
|
Looking into it.. |
Signed-off-by: Aditya Chopra <adityachopra2912@gmail.com>
|
I had made the changes a few days ago, could someone please run the CI? Also is there a better alternative for doing the same? I dont want to nag anybody repeatedly. Thanks! |
5 participants
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes the CI issue coming in PR #22591
Please indicate you've done the following: