Skip to content

Conversation

@amyssnippet
Copy link

This change adds a new ShutdownGracePeriod field to net/http.Server to support HTTP/2 graceful shutdown as proposed in issue #77229.

Changes

  • Added ShutdownGracePeriod time.Duration field to the Server struct
  • Added comprehensive documentation explaining the field's purpose
  • Added test TestServerShutdownGracePeriod to verify field behavior

Behavior

  • Default value is 0, maintaining backward compatibility
  • When > 0, HTTP/2 connections will wait this duration after sending the initial GOAWAY frame before sending the final GOAWAY
  • This prevents client retries of in-flight requests during graceful shutdown

Implementation Notes

  • The HTTP/2 implementation in golang.org/x/net/http2 will need to be updated to utilize this field
  • No breaking changes; existing code continues to work unchanged
  • Follows RFC 7540 Section 6.8 recommendations

Fixes #77229

Add ShutdownGracePeriod field to http.Server to configure the grace
period for HTTP/2 graceful shutdown. When non-zero, this allows
clients time to send in-flight requests before the server closes
HTTP/2 connections, preventing unnecessary retries.

This implements the grace period mechanism described in RFC 7540
Section 6.8 for HTTP/2 graceful shutdown.

Fixes golang#77229
@gopherbot
Copy link
Contributor

This PR (HEAD: 702a086) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/737360.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/737360.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/737360.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Amol Yadav:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/737360.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Amol Yadav:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/737360.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

proposal: net/http: add ShutdownGracePeriod to Server

2 participants