Skip to content

Conversation

@lxq015
Copy link
Contributor

@lxq015 lxq015 commented Jan 24, 2026

Currently, memcombine is disabled for architectures where unaligned
access might be slow or unsupported (unalignedOK = false), such as riscv64.
This leads to significant performance degradation for common operations
like encoding/binary.Uint64, which expand into long sequences of
byte loads, shifts, and ORs.

This change relaxes the global unalignedOK constraint in memcombine.
Instead of a total bailout, it now allows merging loads and stores
if the combined address can be statically proven to be naturally aligned.

By analyzing OpAddr, OpLocalAddr, and constant offsets through OpOffPtr,
the compiler can safely emit a single wide load (e.g., LD on RISC-V)
even when the architecture generally forbids unaligned access.
This provides the performance benefits of load merging for well-aligned
data structures without risking expensive kernel traps on unaligned-unfriendly
hardware.

Updates #736940

@lxq015 lxq015 marked this pull request as draft January 24, 2026 08:25
@gopherbot
Copy link
Contributor

This PR (HEAD: d161768) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/738960.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Jorropo:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/738960.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Keith Randall:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/738960.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants