quoted: applying TestComments in tests #77348
Open
+28
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is a bit of inconsistency in the formatting/output of the failure messages of the tests.
As an example, tests like directive_test.go are using the failure messages as described in https://go.dev/wiki/TestComments#got-before-want.
But some other tests, like the ones in quoted_test.go are using the (not recommended) approach of:
"got %v, want %v"
This PR tries to follow the failure message recommendation described in https://go.dev/wiki/TestComments:
So, as an example, this is a before/after for the two tests I changed:
Split:
Join: