os: support deleting inaccessible files in RemoveAll #77403

michalpristas · 2026-02-02T10:14:32Z

windows: retry file open with DELETE access after access denied

Additional access rights when opening files, including SYNCHRONIZE,
break deletion when the caller has FILE_DELETE_CHILD on the parent
directory but not the file. Retry with DELETE only restores correct
Windows semantics.

Fixes #77402

gopherbot · 2026-02-02T10:27:38Z

This PR (HEAD: ae1e7fa) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/741040.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-02-02T10:37:24Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-02T10:47:16Z

Message from Michal Pristas:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-02T11:45:19Z

Message from Quim Muntal:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

…ws.go

gopherbot · 2026-02-02T16:23:25Z

Message from Michal Pristas:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-02T16:23:35Z

This PR (HEAD: 912d5d2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/741040.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-02-02T17:32:22Z

Message from Damien Neil:

Patch Set 4: Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-02T17:32:22Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-02-02T17:18:43Z","revision":"7c722ba0bd37c3627107d74b843bee6fd09721a2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-02T17:41:53Z

Message from Damien Neil:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-02T17:41:54Z

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):

go on master (change 741040)

To reproduce, try gomote repro 8690958906051132993.

Additional links for debugging:

go tool dist test -json output [shard 4]

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-02T17:41:54Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-02T18:22:39Z

This PR (HEAD: 6e975ca) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/741040.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-02-02T18:32:23Z

Message from Michal Pristas:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-02T18:59:53Z

Message from Quim Muntal:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-03T10:27:05Z

Message from Michal Pristas:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-03T10:27:06Z

Message from Michal Pristas:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-03T10:28:40Z

This PR (HEAD: 92db103) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/741040.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-02-03T15:03:47Z

Message from Quim Muntal:

Patch Set 6:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-03T15:03:48Z

Message from Quim Muntal:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-03T15:34:16Z

This PR (HEAD: efd42c2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/741040.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-02-03T15:45:28Z

Message from Michal Pristas:

Patch Set 6:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-04T09:05:37Z

Message from Quim Muntal:

Patch Set 7:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-04T09:36:55Z

Message from Michal Pristas:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-04T09:37:05Z

This PR (HEAD: 0ad635c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/741040.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-02-04T09:47:41Z

Message from Michal Pristas:

Patch Set 7:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-04T09:47:42Z

Message from Quim Muntal:

Patch Set 8: Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-04T09:47:43Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-02-04T09:39:07Z","revision":"10b3cbdef061e0779ca45cd7c0d46b8fbad85373"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-04T10:08:20Z

Message from Quim Muntal:

Patch Set 8: -Commit-Queue

(Posted by golang-scoped@luci-project-accounts.iam.gserviceaccount.com on behalf of quimmuntal@gmail.com)

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-04T10:08:20Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-04T10:08:21Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2026-02-06T17:39:13Z

Message from Michael Knyszek:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/741040.
After addressing review feedback, remember to publish your drafts!

windows: retry file open with DELETE access after access denied Additional access rights when opening files, including SYNCHRONIZE, break deletion when the caller has FILE_DELETE_CHILD on the parent directory but not the file. Retry with DELETE only restores correct Windows semantics. Fixes #77402 Change-Id: Ie53bc6f1673de1a8af4dcfb7496daf99e71098cb GitHub-Last-Rev: 0ad635c GitHub-Pull-Request: #77403 Reviewed-on: https://go-review.googlesource.com/c/go/+/741040 Reviewed-by: Quim Muntal <quimmuntal@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>

gopherbot · 2026-02-06T19:39:21Z

This PR is being closed because golang.org/cl/741040 has been merged.

windows: handle STATUS_ACCESS_DENIED by retrying with DELETE access

ae1e7fa

This was referenced Feb 2, 2026

Bump Go version to 1.25.4 elastic/beats#46793

Draft

os: Go 1.25.x regression on RemoveAll for windows #77402

Closed

removed synchronize and moved STATUS_ACCESS_DENIED into syscall_windo…

912d5d2

…ws.go

reverted tests in progress

6e975ca

Added tests for deleteat

92db103

Refactor: move types and syscall definition

efd42c2

moved const definitions into types_windows

0197add

moved const definitions into types_windows

0ad635c

gopherbot closed this Feb 6, 2026

os: support deleting inaccessible files in RemoveAll #77403

os: support deleting inaccessible files in RemoveAll #77403

Conversation

michalpristas commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 2, 2026

Uh oh!

gopherbot commented Feb 3, 2026

Uh oh!

gopherbot commented Feb 3, 2026

Uh oh!

gopherbot commented Feb 3, 2026

Uh oh!

gopherbot commented Feb 3, 2026

Uh oh!

gopherbot commented Feb 3, 2026

Uh oh!

gopherbot commented Feb 3, 2026

Uh oh!

gopherbot commented Feb 3, 2026

Uh oh!

gopherbot commented Feb 4, 2026

Uh oh!

gopherbot commented Feb 4, 2026

Uh oh!

gopherbot commented Feb 4, 2026

Uh oh!

gopherbot commented Feb 4, 2026

Uh oh!

gopherbot commented Feb 4, 2026

Uh oh!

gopherbot commented Feb 4, 2026

Uh oh!

gopherbot commented Feb 4, 2026

Uh oh!

gopherbot commented Feb 4, 2026

Uh oh!

gopherbot commented Feb 4, 2026

Uh oh!

gopherbot commented Feb 6, 2026

Uh oh!

gopherbot commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

michalpristas commented Feb 2, 2026 •

edited

Loading