Skip to content

Conversation

@GeorgeSapkin
Copy link

The assembler's retpoline pass for Spectre mitigations did not recognize
several indirect CALL instructions, causing assembly failures with:

# internal/runtime/gc/scan
asm: non-retpoline-compatible: 00005 (/path_to_go/src/internal/runtime/gc/scan/scan_amd64.s:15) CALL (BX)(CX8)
asm: non-retpoline-compatible: 00015 (/path_to_go/src/internal/runtime/gc/scan/scan_amd64.s:28) CALL (BX)(CX
8)
asm: assembly failed
# internal/runtime/startlinetest
asm: non-retpoline-compatible: 00005 (/path_to_go/src/internal/runtime/startlinetest/func_amd64.s:27) CALL (DX)
asm: assembly failed

Adapt the calls in func_amd64.s and scan_amd64.s to allow the assembler to
correctly apply retpolines and fix the build with Spectre mitigations
enabled.

I'm not certain about the syntax or the exact registers (e.g. R11), but
go tool dist test passes on target. There's probably a better approach.

Commits are split in case this needs backporting, since paths are different
on <1.26.

Fixes #77420

@gopherbot
Copy link
Contributor

This PR (HEAD: aef3c28) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/741241.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

The assembler's retpoline pass for Spectre mitigations did not recognize
several indirect CALL instructions, causing assembly failures with:

# internal/runtime/gc/scan
asm: non-retpoline-compatible: 00005 (/path_to_go/src/internal/runtime/gc/scan/scan_amd64.s:15) CALL    (BX)(CX*8)
asm: non-retpoline-compatible: 00015 (/path_to_go/src/internal/runtime/gc/scan/scan_amd64.s:28) CALL    (BX)(CX*8)
asm: assembly failed

Adapt the calls in scan_amd64.s to allow the assembler to correctly
apply retpolines and fix the build with Spectre mitigations enabled.

Fixes golang#77420
The assembler's retpoline pass for Spectre mitigations did not recognize
several indirect CALL instructions, causing assembly failures with:

# internal/runtime/startlinetest
asm: non-retpoline-compatible: 00005 (/path_to_go/src/internal/runtime/startlinetest/func_amd64.s:27)   CALL    (DX)
asm: assembly failed

Adapt the calls in func_amd64.s to allow the assembler to correctly
apply retpolines and fix the build with Spectre mitigations enabled.

Fixes golang#77420
@GeorgeSapkin GeorgeSapkin force-pushed the fix/calls-for-retpoline branch from aef3c28 to 8da87b0 Compare February 3, 2026 15:41
@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/741241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/741241.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 8da87b0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/741241.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

LEAQ ·gcExpandersAVX512(SB), BX
CALL (BX)(CX*8)
MOVQ (BX)(CX*8), R11
CALL R11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

93048 32459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

internal/runtime: some modules fail to compile when Spectre mitigations are enabled

3 participants