Skip to content

Remove dependency on github.com/janpfeifer/must in ops_generator#7

Merged
janpfeifer merged 3 commits intomainfrom
remove-must-dependency
Dec 2, 2025
Merged

Remove dependency on github.com/janpfeifer/must in ops_generator#7
janpfeifer merged 3 commits intomainfrom
remove-must-dependency

Conversation

@google-labs-jules
Copy link
Contributor

Removed the dependency on github.com/janpfeifer/must from internal/cmd/ops_generator.
Defined local must and must1 helper functions in internal/cmd/ops_generator/main.go using log.Fatalf for error handling.
Updated binary_ops.go and unary_ops.go to use the local helpers instead of the external library.
Removed github.com/janpfeifer/must from go.mod and go.sum.


PR created automatically by Jules for task 1603601399614147070 started by @janpfeifer

Replaced the external `must` dependency with local helper functions `must` and `must1` in `internal/cmd/ops_generator/main.go`. Updated `binary_ops.go` and `unary_ops.go` to use these local functions. Removed the dependency from `go.mod`.
@google-labs-jules
Copy link
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

google-labs-jules bot and others added 2 commits December 2, 2025 18:16
Replaced the external `must` dependency with local helper functions `must` and `must1` in `internal/cmd/ops_generator/main.go`. Updated `binary_ops.go` and `unary_ops.go` to use these local functions. Removed the dependency from `go.mod`.
Refactored `must1` to call `must` internally to centralize error handling.
@janpfeifer janpfeifer marked this pull request as ready for review December 2, 2025 18:20
@janpfeifer janpfeifer merged commit c132c5f into main Dec 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant