-
Notifications
You must be signed in to change notification settings - Fork 538
Introduce Config type for adkrest #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kenasvarghese
wants to merge
12
commits into
google:main
Choose a base branch
from
Kenasvarghese:adkrest-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ce96303
Introduce Config type for adkrest
Kenasvarghese 9c31f05
Move SSEWriteTimeout into Config
Kenasvarghese 6096357
Update adkrest example to use Config
Kenasvarghese b53c5a8
Update web api to use adkrest config
Kenasvarghese 4bae975
Initialize ArtifactService in example config
Kenasvarghese 82ebc99
Add validation for adkrest Config
Kenasvarghese bddbdce
Unexport Config.validate and fix style
Kenasvarghese 3072be6
Merge branch 'main' into adkrest-config
Kenasvarghese 09b6aee
Add new field to config for compatibility with main
Kenasvarghese 6e9309e
Merge remote-tracking branch 'upstream' into adkrest-config
Kenasvarghese 612afe0
Add new field to config for compatibility with main
Kenasvarghese 4fb6ce5
Merge branch 'main' into adkrest-config
Kenasvarghese File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // Copyright 2025 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package adkrest | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "google.golang.org/adk/agent" | ||
| "google.golang.org/adk/artifact" | ||
| "google.golang.org/adk/session" | ||
| ) | ||
|
|
||
| // Config defines the services and loaders required by the adkrest package. | ||
| type Config struct { | ||
| SessionService session.Service | ||
| ArtifactService artifact.Service | ||
| AgentLoader agent.Loader | ||
| SSEWriteTimeout time.Duration | ||
| } | ||
Kenasvarghese marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.