fix(server): prevent panic in SSE handler on error

[maishivamhoo123]

Fixes #383

Description
This PR addresses a stability issue in RunSSEHandler where the server would panic or enter an infinite loop if the LLM provider returned an error (e.g., invalid API key) during streaming.

The Bug: The error handling logic inside the event loop used continue after encountering a stream error. This caused the loop to attempt reading from a broken or closed stream repeatedly, causing a panic.

The Fix: Replaced continue with return nil in server/adkrest/controllers/runtime.go. This ensures the handler exits the request loop gracefully when a fatal error occurs.

Verification
Before Fix (Panic/Crash): The server crashes with a panic when an invalid API key is used.

After Fix (Graceful Exit): The server returns the error to the client and remains stable without crashing.

[gemini-code-assist]

Summary of Changes

Hello @maishivamhoo123, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical stability flaw in the server's SSE handling mechanism. Previously, an error from an LLM provider during streaming could lead to the server panicking or entering an infinite loop. The core of the fix involves modifying the error handling logic within the RunSSEHandler to ensure that upon encountering a fatal stream error, the handler exits cleanly instead of attempting to continue, thereby preventing application crashes and improving overall system robustness.

Highlights

• Prevented Server Panics: The pull request resolves an issue where the server would panic or enter an infinite loop when the LLM provider returned an error during Server-Sent Events (SSE) streaming.
• Graceful Error Handling: The fix ensures that the RunSSEHandler now gracefully exits the request loop by returning nil when a fatal stream error occurs, rather than attempting to continue processing a broken stream.
• Improved Stability: This change significantly enhances the stability of the SSE handler, preventing crashes caused by invalid API keys or other LLM provider errors.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a critical panic in the SSE handler by replacing continue with return nil on stream errors. This ensures the handler exits gracefully. I've added one suggestion for a future improvement to make error reporting more robust.