Removed redundant code checking wrt in nnx.Optimizer

[vfdev-5]

Description:

• Removed redundant code checking wrt in nnx.Optimizer. This is already done in the @_check_wrt_arg_passed decorator.

[gemini-code-assist]

Summary of Changes

Hello @vfdev-5, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the nnx.Optimizer initialization process by eliminating a duplicate check for the presence of the wrt argument. The validation logic for this argument is already robustly managed by an existing decorator, making the removed code unnecessary and improving overall code clarity and maintainability.

Highlights

• Code Redundancy Removal: Removed a redundant check for the wrt argument within the nnx.Optimizer's __init__ method, as this validation is already handled by the @_check_wrt_arg_passed decorator.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• flax/nnx/training/optimizer.py
  • Removed the if isinstance(wrt, _Missing): block and its associated TypeError raise from the __init__ method of nnx.Optimizer.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes a redundant check for the wrt argument within the nnx.Optimizer.__init__ method. As correctly pointed out in the description, this check is already performed by the @_check_wrt_arg_passed decorator. The change is a good cleanup, simplifying the code and removing duplication. I see no issues with this modification.