maintain data/static definition in split / state#5227
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
maintain data/static definition in split / state#5227copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
`nnx.graph` APIs now follow the data / static definitions for `nnx.Pytree` instances. Previously `nnx.graph.flatten` match the default definitions for Pytree most of the time but deviated on edcases, now they always match. Example
```python
class Foo(nnx.Pytree):
def __init__(self, data, static):
self.data = nnx.data(data)
self.static = nnx.static(static)
tree = Foo(1, 2)
state = nnx.state(tree)
# previously this was false
assert 'data' in state
```
PiperOrigin-RevId: 866680531
8133aa7 to
124e33f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maintain data/static definition in split / state
nnx.graphAPIs now follow the data / static definitions fornnx.Pytreeinstances. Previouslynnx.graph.flattenmatch the default definitions for Pytree most of the time but deviated on edcases, now they always match. Example