Skip to content

Adding magic technology and setup files and the netgen setup file#66

Open
RTimothyEdwards wants to merge 1 commit intogoogle:mainfrom
RTimothyEdwards:open_pdks
Open

Adding magic technology and setup files and the netgen setup file#66
RTimothyEdwards wants to merge 1 commit intogoogle:mainfrom
RTimothyEdwards:open_pdks

Conversation

@RTimothyEdwards
Copy link
Collaborator

Per request from Tim Ansell, current versions of the open_pdks setups and technology files for magic and netgen copied and pushed to the gf180mcu_fd_pr/tech/ directory.

Copy link
Contributor

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files are missing appropriate license headers. Could you please add them.

@mithro mithro requested review from QuantamHD and proppy November 4, 2022 15:46
@proppy
Copy link
Member

proppy commented Nov 7, 2022

Thanks for adding those!

@RTimothyEdwards is there any regression testing in place in open_pdks for those rules that we can import, or should we log an issue to create a setup similar to what's currently in https://github.com/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/tree/main/rules/klayout/drc/testing?

@proppy
Copy link
Member

proppy commented Nov 9, 2022

Fixes #31

proppy pushed a commit to proppy/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Feb 6, 2023
@curtisma
Copy link
Contributor

@QuantamHD This is another important PR, Do you think we can merge it also?

@QuantamHD
Copy link
Collaborator

@RTimothyEdwards Still need to the license headers before this can be merged.

Also are there any CI tests available today? If not that's fine I'll still merge it

@RTimothyEdwards
Copy link
Collaborator Author

Stick a licence header on whatever needs a license header, then. Netgen and magic scripts are all Tcl and can use # as a comment line header. The magic .tech file will also take # as a comment line header.

@RTimothyEdwards
Copy link
Collaborator Author

I was working on CI tests with Sai Charan, but the ball's still in my court for creating repositories for the CI tests.

@QuantamHD
Copy link
Collaborator

Alright, is it Efabless' or Tim Edward's copyright?

@RTimothyEdwards
Copy link
Collaborator Author

I usually copyright things I wrote myself to me, but I guess it doesn't really matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants