Skip to content

feat: Add organization artifact metadata APIs#3944

Open
maishivamhoo123 wants to merge 20 commits intogoogle:masterfrom
maishivamhoo123:feat/artifactMetaData
Open

feat: Add organization artifact metadata APIs#3944
maishivamhoo123 wants to merge 20 commits intogoogle:masterfrom
maishivamhoo123:feat/artifactMetaData

Conversation

@maishivamhoo123
Copy link
Contributor

@maishivamhoo123 maishivamhoo123 commented Jan 27, 2026

Description

This PR implements the Organization Artifact Metadata APIs as requested in #3917.
This version corrects the scope from Repository to Organization level.

Changes

  • Logic: Moved implementation to github/orgs_artifacts.go.
  • Endpoints Added:
    • POST /orgs/{org}/artifacts/metadata/deployment-record
    • POST /orgs/{org}/artifacts/metadata/deployment-record/cluster/{cluster}
    • POST /orgs/{org}/artifacts/metadata/storage-record
    • GET /orgs/{org}/artifacts/{subject_digest}/metadata/deployment-records
    • GET /orgs/{org}/artifacts/{subject_digest}/metadata/storage-records
  • Testing: Added comprehensive unit tests in github/orgs_artifacts_test.go.
  • Generated: Updated github-accessors.go and github-stringify_test.go via script/generate.sh.

Checklist

  • I have reviewed my own diff for unnecessary changes.
  • All tests pass (script/test.sh).
  • Code is linted (script/lint.sh).
  • Ran script/generate.sh.

Fixes #3917

@gmlewis gmlewis changed the title feat: implement organization artifact metadata APIs feat: Add organization artifact metadata APIs Jan 27, 2026
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jan 27, 2026
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.62%. Comparing base (5126e84) to head (48c79f6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3944      +/-   ##
==========================================
+ Coverage   93.60%   93.62%   +0.01%     
==========================================
  Files         204      205       +1     
  Lines       17411    17461      +50     
==========================================
+ Hits        16298    16348      +50     
  Misses        912      912              
  Partials      201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maishivamhoo123
Copy link
Contributor Author

@gmlewis Sir can you please review the code?

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maishivamhoo123, @alexandear , and @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @zyfy29

@maishivamhoo123
Copy link
Contributor Author

@Not-Dhananjay-Mishra can you please check once i think the latest pr is able to meet all your requirements?

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jan 31, 2026
@gmlewis gmlewis changed the title feat: Add organization artifact metadata APIs feat!: Add organization artifact metadata APIs Jan 31, 2026
@gmlewis gmlewis changed the title feat!: Add organization artifact metadata APIs feat: Add organization artifact metadata APIs Jan 31, 2026
@gmlewis gmlewis removed the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Jan 31, 2026
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maishivamhoo123!
All new tests need to add a call to testBadOptions to improve code coverage. Please search the repo for examples using testBadOptions and do likewise.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maishivamhoo123!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra

maishivamhoo123 and others added 5 commits February 3, 2026 01:41
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
Co-authored-by: Dhananjay Mishra <technicaldmcontact@gmail.com>
@maishivamhoo123
Copy link
Contributor Author

@alexandear , @Not-Dhananjay-Mishra , @gmlewis can you please review the changes , I made all the suggested changes .

Copy link
Contributor

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for new Artifact Metadata endpoints

4 participants