This repository was archived by the owner on Jan 21, 2026. It is now read-only.
performance: declare gumbo_debug as inline function#383
Open
detailyang wants to merge 2 commits intogoogle:masterfrom
Open
performance: declare gumbo_debug as inline function#383detailyang wants to merge 2 commits intogoogle:masterfrom
detailyang wants to merge 2 commits intogoogle:masterfrom
Conversation
gumbo_debug should be declared as inline function to eliminate the overhead of function call even if it's compiled on release mode
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now using the perf profiler on user space to benchmark gumbo_parser at Centos6.5 as the following:
It shows the gumbo_debug function will occupy approximate %1.10 On-CPU at


retqinstruction.and
To eliminate the overhead of function call even if it's compiled on release mode, gumbo_debug should be declared as inline function.
Also apply @stevecheckoway's PR #378 to pass CI.
@nostrademons Can you have a look at it ? Many thanks !