-
Notifications
You must be signed in to change notification settings - Fork 455
chore: ignore 429 (too busy) responses from github w/ markdown link checker #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @kevmoo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintenance and cleanup tasks. It introduces a configuration change to the markdown link checker to gracefully handle GitHub API rate limits, thereby improving the reliability of link validation. Concurrently, it streamlines the repository by removing an unnecessary markdown linter configuration file, contributing to a cleaner and more efficient project setup. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a configuration for the markdown link checker to ignore 429 (Too Busy) responses from GitHub, which is a good measure to prevent CI failures due to rate limiting. It also removes an apparently unused .markdownlint.yaml file, which is good repository hygiene. I've found one minor issue in the new configuration file regarding an unescaped character in a regular expression and have provided a suggestion to fix it. Otherwise, the changes look good.
8752f98 to
66076a4
Compare
ed4b3f2 to
d778205
Compare
6883f68 to
d1c91ea
Compare
Also remove unused .markdownlint.yaml file