#1678 - Set overwrite flag on copyWithTimestamp based on if a file or not#2211
Open
jsoberg wants to merge 1 commit intogoogle:mainfrom
Open
#1678 - Set overwrite flag on copyWithTimestamp based on if a file or not#2211jsoberg wants to merge 1 commit intogoogle:mainfrom
jsoberg wants to merge 1 commit intogoogle:mainfrom
Conversation
…a file or directory, vs always being false
Author
|
Added further explanation here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the
FileAlreadyExistsExceptionfrom #1678, as called out by @jonamireh here. Ultimately this appears to be a symptom of a larger issue; If this fixes the repeatedFileAlreadyExistsExceptionthrown during rebuilds in the meantime, however, it would be a good bridge for maintaining developer velocity since this issue causes almost every build to require a manual rebuild (or, disabling incremental KSP builds) for the team that I work on.