Merged
Conversation
ResetSetElements resets the stateful expressions (e.g., counters) of all elements in the specified set. The reset is applied immediately (no Flush is required) and the returned elements reflect their state prior to the reset. This update also adds a reset flag to the internal getSetElements method, along with a safeguard for situations where the user provides no valid set identifier.
nickgarlis
force-pushed
the
add-get-setelem-reset
branch
from
56ec7cb to
df1ed79
Compare
nickgarlis
commented
Nov 18, 2025
| flags := netlink.Request | ||
| attrs := []netlink.Attribute{ | ||
| {Type: unix.NFTA_SET_ELEM_LIST_TABLE, Data: []byte(s.Table.Name + "\x00")}, | ||
| {Type: unix.NFTA_SET_ELEM_LIST_SET, Data: []byte(s.Name + "\x00")}, |
Contributor
Author
There was a problem hiding this comment.
This one was accidentally duplicated in the if statement below but luckily it didn't cause any bugs
stapelberg
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResetSetElements resets the stateful expressions (e.g., counters) of all elements in the specified set. The reset is applied immediately (no Flush is required) and the returned elements reflect their state prior to the reset. This update also adds a reset flag to the internal getSetElements method, along with a safeguard for situations where the user provides no valid set identifier.
Also, many thanks for the prior reviews!