Add CodeArea validity, better error-checking in Decode().#185
Open
viettaml wants to merge 11 commits intogoogle:mainfrom
Open
Add CodeArea validity, better error-checking in Decode().#185viettaml wants to merge 11 commits intogoogle:mainfrom
viettaml wants to merge 11 commits intogoogle:mainfrom
Conversation
Catch up to google/open-location-code
Contributor
|
@viettaml are you able to take a look at the conflicts? |
Contributor
Author
Done (I think). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Augment & streamline Decode() to do some minimal error checking that can report some invalid code inputs by returning an invalid CodeArea. Add CodeArea::IsValid() and CodeArea::InvalidCodeArea() methods to facilitate checking for & returning invalid CodeArea objects. Add basic unit tests for CodeArea methods.