Attempt to speed up Docker image creation#14874
Open
mhucka wants to merge 6 commits intogoogle:masterfrom
Open
Attempt to speed up Docker image creation#14874mhucka wants to merge 6 commits intogoogle:masterfrom
mhucka wants to merge 6 commits intogoogle:masterfrom
Conversation
Changes: * Combine `apt-get update` and `apt-get install` into a single `RUN`, for greater efficiency. * Skip installing `apt-system-requirements.txt` because they shouldn't be needed for fuzzing. * Replace `cat` with `grep -vhE '^#|^$'` to strip comments and blank lines before sending requirements to `apt-get install` * Add `--mount=type=cache` flags in the hopes that you change a requirement previously downloaded `.deb` files are reused rather than re-downloaded from the internet. * Silence irrelevant pip warnings about installing in system directories.
Fix copy-paste error.
I just realized that the packages this was installing via apt are not necessary for the fuzzing procedure.
Removeo more things that I had added when configuring the apt installation earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Remove
aptinstallation of packages because they are not needed for fuzzing.Combine separate
RUNsteps into one, where possible.Add
--mount=type=cacheflags in the hopes that you change a requirement previously downloaded.debfiles are reused rather than re-downloaded from the internet.Silence irrelevant pip warnings about installing in system directories.