Open
Conversation
cphlipot1
force-pushed
the
dev/cphlipot1/perf_sample_weighting_1
branch
from
7b86a44 to
b8f10be
Compare
🎨 Perfetto UI Build✅ UI build is ready: https://storage.googleapis.com/perfetto-ci-artifacts/gh-21533078833-1-ui/ui/index.html |
cphlipot1
force-pushed
the
dev/cphlipot1/perf_sample_weighting_1
branch
from
b8f10be to
3913f37
Compare
Member
LalitMaganti
left a comment
LalitMaganti
left a comment
There was a problem hiding this comment.
Some initial comments, overall direciton looks good!
src/trace_processor/importers/proto/perf_counter_set_tracker.cc
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/intrinsics/functions/perf_counter.cc
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/intrinsics/functions/perf_counter.cc
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/intrinsics/functions/perf_counter.cc
Outdated
Show resolved
Hide resolved
src/trace_processor/perfetto_sql/stdlib/linux/perf/counters.sql
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
Thanks. i tried to address feedback but had a few questions. |
…nd "DELEGATES TO"
src/trace_processor/perfetto_sql/intrinsics/functions/perf_counter.h
Outdated
Show resolved
Hide resolved
LalitMaganti
reviewed
Feb 4, 2026
Member
|
Largely LGTM! Just a few last nits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements RFC-0015 (#4545) to make it easy to correlate sample callstacks with the associated counter values. The intention is to use this to help weight perf event flamegraphs by the event values, rather than sample values
Bug: #4527