traceconv: add support for Android traces to bundle command #4663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Holding off on this. I want to change the approach. |
It's only used by trace procesor and traceconv so doesn't make sense to live in src/profiling. Move it to a place where it can be reused.
It's only used by trace_processor_shell and traceconv so it should live in the util folder.
LalitMaganti
force-pushed
the
dev/lalitm/symbol
branch
from
76a1d23 to
7555ee7
Compare
LalitMaganti
force-pushed
the
dev/lalitm/symbol
branch
from
7555ee7 to
ba789d6
Compare
Member
Author
|
OK now should be a lot cleaner. Though followups will improve things further. |
sashwinbalaji
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundle command until now only supported Linux traces. Let's also add
support for Android traces. This also needs us to support deobufscation
as well, not just symbolization.