Support multiple -add_comment arguments#987
Open
camillobruni wants to merge 2 commits intogoogle:mainfrom
Open
Support multiple -add_comment arguments#987camillobruni wants to merge 2 commits intogoogle:mainfrom
camillobruni wants to merge 2 commits intogoogle:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
=======================================
Coverage 67.35% 67.35%
=======================================
Files 44 44
Lines 7792 7792
=======================================
Hits 5248 5248
Misses 2112 2112
Partials 432 432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aalexand
reviewed
Jan 15, 2026
Collaborator
aalexand
left a comment
There was a problem hiding this comment.
I think the test implementation testFlags is different from internal/driver/flags.go. I'm not sure GoFlags there support multiple flags properly. Could you test that manually? Please also check that this change does not make the comma a separator as we want something like -add_comment=hello,world to add one comment, not two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it a bit nicer to annotate profiles when using external tools.