Open
Conversation
jmr
requested changes
Oct 5, 2025
Member
jmr
left a comment
jmr
left a comment
There was a problem hiding this comment.
Adding this to bazel.yml would be good, too, but can also be done separately.
src/.bazelrc
Outdated
| build:asan --copt -DADDRESS_SANITIZER | ||
| build:asan --copt -D_GLIBCXX_SANITIZE_VECTOR | ||
| build:asan --copt -O1 | ||
| build:asan --copt -g |
Member
There was a problem hiding this comment.
A lot of these seem orthogonal and part of -c dbg.
Contributor
Author
There was a problem hiding this comment.
You can theoretically use this with -c opt or -c fastbuild too, it's probably wise to override them because if you have e.g. -O3 on and the compiler elides problematic reads/writes then you'll get false negatives.
smcallis
force-pushed
the
add-asan-config
branch
from
938c331 to
a090c12
Compare
Enables ASAN builds with e.g. bazel -c opt --config=asan <targets>
smcallis
force-pushed
the
add-asan-config
branch
from
a090c12 to
c918baf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables ASAN builds with e.g. bazel -c opt --config=asan