fix: Add fallback byteswap/endian implementations for older abseil versions#491
Open
yharby wants to merge 2 commits intogoogle:masterfrom
Open
fix: Add fallback byteswap/endian implementations for older abseil versions#491yharby wants to merge 2 commits intogoogle:masterfrom
yharby wants to merge 2 commits intogoogle:masterfrom
Conversation
…rsions s2geometry v0.13.1 uses absl::byteswap() and absl::endian which were only added in abseil LTS 2025.01.27. This causes compilation failures when building with older abseil versions. This commit adds: - Fallback byteswap implementations using compiler intrinsics (__builtin_bswap16/32/64 for GCC/Clang) with manual fallbacks - Compile-time endianness detection via __BYTE_ORDER__ macros - Maintains backwards compatibility while still working with newer abseil Fixes google#489
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__BYTE_ORDER__macrosProblem
s2geometry v0.13.1 uses
absl::byteswap()andabsl::endianinsrc/s2/util/endian/endian.h, which were only added in abseil LTS 2025.01.27. This causes compilation failures when building with older abseil versions that many package managers still provide:Solution
This PR adds fallback implementations that:
__builtin_bswap16/32/64compiler intrinsics (GCC/Clang) with manual fallbacks for other compilers__BYTE_ORDER__macrosTesting
Fixes #489