S2Cell::Contains: Increase expansion to 5/3*DBL_EPSILON#535
Merged
jmr merged 1 commit intogoogle:masterfrom Jan 28, 2026
Merged
S2Cell::Contains: Increase expansion to 5/3*DBL_EPSILON#535jmr merged 1 commit intogoogle:masterfrom
jmr merged 1 commit intogoogle:masterfrom
Conversation
The required expansion is 5/3*DBL_EPSILON, not DBL_EPSILON, as explained in google#463 (comment) The comment should be expanded, but this will at least fix the flaky test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required expansion is 5/3*DBL_EPSILON, not DBL_EPSILON, as explained in #463 (comment)
The comment should be expanded, but this will at least fix the flaky test.