fix: restrict to a choice of a list of values the --target option in api command#327
Open
smehboub wants to merge 1 commit intogoogle:masterfrom
Open
fix: restrict to a choice of a list of values the --target option in api command#327smehboub wants to merge 1 commit intogoogle:masterfrom
--target option in api command#327smehboub wants to merge 1 commit intogoogle:masterfrom
Conversation
--target option in api command
11ccc35 to
69c0b5a
Compare
Contributor
Author
|
Hello @lvaylet Any news please ? Thanks in advance. Sophian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
When we execute :
We get the error :
It is better to validate the value of the --target parameter as you already do with the --signature-type parameter, here : https://github.com/google/slo-generator/blob/master/slo_generator/cli.py#L148
Thanks in advance for feedbacks.
Rgs,