Open
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
joshlf
force-pushed
the
G1797ed669d2bae97562a2b84e0ac229b00d5acb7
branch
from
0d5e54c to
e2f523f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## Gd4257e94754893127a547297565b5e06f6eeeba8 #2953 +/- ##
============================================================================
Coverage ? 92.01%
============================================================================
Files ? 19
Lines ? 6022
Branches ? 0
============================================================================
Hits ? 5541
Misses ? 481
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gherrit-pr-id: Gd4257e94754893127a547297565b5e06f6eeeba8
Rename it to `Ptr::try_with` and remove the old method of the same name. In order to guarantee that the `f` closure doesn't leak its argument, make `f` variant on lifetime (ie, for `f: F`, go from `F: FnOnce` to `F: for<'b> FnOnce`). gherrit-pr-id: G1797ed669d2bae97562a2b84e0ac229b00d5acb7
joshlf
force-pushed
the
G1797ed669d2bae97562a2b84e0ac229b00d5acb7
branch
from
e2f523f to
01118b6
Compare
joshlf
changed the base branch from
main
to
Gd4257e94754893127a547297565b5e06f6eeeba8
Merged
Base automatically changed from
Gd4257e94754893127a547297565b5e06f6eeeba8
to
main
February 2, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename it to
Ptr::try_withand remove the old method of the same name.In order to guarantee that the
fclosure doesn't leak its argument,make
fvariant on lifetime (ie, forf: F, go fromF: FnOncetoF: for<'b> FnOnce).Ptr::try_with_as_{ref,mut}#2952Ptr::try_with_uncheckedsafe #2953Cargo.lock#2957Latest Update: v3 — Compare vs v2
📚 Full Patch History
Links show the diff between the row version and the column version.
Stacked PRs enabled by GHerrit.