-
Notifications
You must be signed in to change notification settings - Fork 31
feat: Introduce asynchronous DDL execution modes #729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
bhatt4982
commented
Jan 20, 2026
- support modes SYNC, ASYNC and ASYNC_WAIT
- returns operationIDs for DDL statements.
Summary of ChangesHello @bhatt4982, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the flexibility of DDL (Data Definition Language) execution by introducing explicit asynchronous modes. Users can now choose to execute DDL statements synchronously (waiting for completion), fully asynchronously (returning immediately with an operation ID), or in a hybrid asynchronous-wait mode (waiting for a fixed duration before returning an operation ID if not completed). This change provides greater control over DDL operations, enabling non-blocking schema changes and better integration with applications that require immediate feedback or background processing. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces asynchronous DDL execution modes (SYNC, ASYNC, and ASYNC_WAIT) and provides operation IDs for DDL statements. The implementation correctly handles the different execution behaviors for each mode, including the timeout logic for ASYNC_WAIT. New test cases have been added to validate these modes, and the mocking infrastructure has been updated to support long-running operations. The changes are well-structured and align with the stated objectives of the pull request.
|
|
||
| // Reduce timeout for testing | ||
| originalTimeout := ddlAsyncWaitTimeout | ||
| ddlAsyncWaitTimeout = 100 * time.Millisecond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifying a global variable (ddlAsyncWaitTimeout) directly within a test, even with a defer to reset it, can introduce subtle race conditions or non-deterministic behavior if tests are run concurrently and the reset is not guaranteed to happen before another test reads the value. Consider making this timeout configurable per test or using a test-specific mock to ensure better isolation and parallel test execution safety.
| } | ||
|
|
||
|
|
||
| var ddlAsyncWaitTimeout = 10 * time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ddlAsyncWaitTimeout is defined as a global variable. While its purpose is clear, global mutable state can be a source of unexpected side effects and make testing or concurrent usage more complex. Consider making this timeout configurable through connection properties or passing it as a parameter to waitForDDLOperation to improve modularity and reduce potential coupling issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should indeed be a connection property. 10s sounds like a reasonable default, but it should be something that an application developer can change to fit their needs.