Skip to content

Conversation

@bhatt4982
Copy link
Contributor

  • support modes SYNC, ASYNC and ASYNC_WAIT
  • returns operationIDs for DDL statements.

@bhatt4982 bhatt4982 requested a review from a team as a code owner January 20, 2026 09:29
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @bhatt4982, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the flexibility of DDL (Data Definition Language) execution by introducing explicit asynchronous modes. Users can now choose to execute DDL statements synchronously (waiting for completion), fully asynchronously (returning immediately with an operation ID), or in a hybrid asynchronous-wait mode (waiting for a fixed duration before returning an operation ID if not completed). This change provides greater control over DDL operations, enabling non-blocking schema changes and better integration with applications that require immediate feedback or background processing.

Highlights

  • New DDL Execution Modes: Introduced SYNC, ASYNC, and ASYNC_WAIT modes for DDL statements, configurable via a new connection property.
  • Operation ID Retrieval: DDL statements executed in ASYNC or ASYNC_WAIT modes now return an OperationID through the SpannerResult interface.
  • Asynchronous Batch DDL: RUN BATCH DDL operations can now return their OperationID when executed asynchronously.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces asynchronous DDL execution modes (SYNC, ASYNC, and ASYNC_WAIT) and provides operation IDs for DDL statements. The implementation correctly handles the different execution behaviors for each mode, including the timeout logic for ASYNC_WAIT. New test cases have been added to validate these modes, and the mocking infrastructure has been updated to support long-running operations. The changes are well-structured and align with the stated objectives of the pull request.


// Reduce timeout for testing
originalTimeout := ddlAsyncWaitTimeout
ddlAsyncWaitTimeout = 100 * time.Millisecond
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Modifying a global variable (ddlAsyncWaitTimeout) directly within a test, even with a defer to reset it, can introduce subtle race conditions or non-deterministic behavior if tests are run concurrently and the reset is not guaranteed to happen before another test reads the value. Consider making this timeout configurable per test or using a test-specific mock to ensure better isolation and parallel test execution safety.

}


var ddlAsyncWaitTimeout = 10 * time.Second
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ddlAsyncWaitTimeout is defined as a global variable. While its purpose is clear, global mutable state can be a source of unexpected side effects and make testing or concurrent usage more complex. Consider making this timeout configurable through connection properties or passing it as a parameter to waitForDDLOperation to improve modularity and reduce potential coupling issues.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should indeed be a connection property. 10s sounds like a reasonable default, but it should be something that an application developer can change to fit their needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants