test: add tests for partitioned queries to the .NET wrapper#747
test: add tests for partitioned queries to the .NET wrapper#747
Conversation
Summary of ChangesHello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the necessary infrastructure and testing to support partitioned queries within the .NET wrapper for SpannerLib. It extends the mock server to simulate the partitioning process and adapts its query execution to handle partition-specific tokens. A new, robust test case has been added to ensure that the .NET wrapper correctly processes and aggregates results from these partitioned queries, verifying the feature's functionality. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support and tests for partitioned queries to the .NET wrapper. The changes include implementing PartitionQuery in the mock server and adding a corresponding integration test. The implementation looks solid and the test effectively covers the new functionality. I have one suggestion to improve the test data generation to be more random and less biased.
spannerlib/wrappers/spannerlib-dotnet/spannerlib-dotnet-tests/RowsTests.cs
Outdated
Show resolved
Hide resolved
705c276 to
e6790fb
Compare
Adds a test to verify that partitioned queries work in the .NET wrapper.