chore: Error handling when upload id I'd incorrect for Resumable upload#24234
Open
shubhangi-google wants to merge 6 commits intogoogleapis:mainfrom
Open
chore: Error handling when upload id I'd incorrect for Resumable upload#24234shubhangi-google wants to merge 6 commits intogoogleapis:mainfrom
shubhangi-google wants to merge 6 commits intogoogleapis:mainfrom
Conversation
|
Please fix the title: looks like there are some typos |
cpriti-os
requested changes
Oct 23, 2025
| if response.status.to_i == 404 | ||
| logger.debug { sprintf("Failed to fetch upload session. Response: #{response.status.to_i} - #{response.body}") } | ||
| false | ||
| end |
Contributor
Author
There was a problem hiding this comment.
The call to check the upload ID's status failed with a 404 error. That status code means the upload ID is not recognized by the server, so the process is stopping and returning false.
There was a problem hiding this comment.
Could you also add tests for success cases.
Contributor
Author
There was a problem hiding this comment.
success test cases were added and have been merged already here
cpriti-os
approved these changes
Nov 3, 2025
viacheslav-rostovtsev
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated code to explicitly handle 404 (Not Found) responses, ensuring that operations correctly fail when an upload session ID is invalid.
Error handling done for code implemented in - #21896, #23376
Implementation linked with- googleapis/google-cloud-ruby#30882