Skip to content

chore: add code coverage#32

Merged
averikitsch merged 9 commits intomainfrom
code-coverage
Jan 13, 2025
Merged

chore: add code coverage#32
averikitsch merged 9 commits intomainfrom
code-coverage

Conversation

@vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Dec 11, 2024 •
edited
Loading

Adding code coverage and some tests to boost code coverage to 90%+

@vishwarajanand vishwarajanand added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 11, 2024
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/llama-index-cloud-sql-pg-python API. label Dec 18, 2024
@vishwarajanand vishwarajanand changed the title [WIP] chore: add code coverage chore: add code coverage Jan 3, 2025
@vishwarajanand vishwarajanand removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 3, 2025
@vishwarajanand vishwarajanand marked this pull request as ready for review January 3, 2025 12:11
@vishwarajanand vishwarajanand requested review from a team as code owners January 3, 2025 12:11
averikitsch
averikitsch reviewed Jan 6, 2025
View reviewed changes
tests/test_async_vector_store.py
await aexecute(engine, f'DROP TABLE "{DEFAULT_TABLE_CUSTOM_VS}"')
await aexecute(engine, f'DROP TABLE IF EXISTS "{DEFAULT_TABLE}"')
await aexecute(engine, f'DROP TABLE IF EXISTS "{DEFAULT_TABLE_CUSTOM_VS}"')
await engine.close()
Copy link
Collaborator

@averikitsch averikitsch Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should also close the connector like await engine._connector.close_async().

@averikitsch
Copy link
Collaborator

averikitsch commented Jan 6, 2025

There is a warning:

PytestDeprecationWarning: The configuration option "asyncio_default_fixture_loop_scope" is unset.
--
433 | The event loop scope for asynchronous fixtures will default to the fixture caching scope. Future versions of pytest-asyncio will default the loop scope for asynchronous fixtures to function scope. Set the default fixture loop scope explicitly in order to avoid unexpected behavior in the future. Valid fixture loop scopes are: "function", "class", "module", "package", "session"

Can you add to the pyproject.toml

[tool.pytest.ini_options]
asyncio_default_fixture_loop_scope = "class"

@vishwarajanand vishwarajanand mentioned this pull request Jan 13, 2025
Merged
@vishwarajanand
Copy link
Contributor Author

vishwarajanand commented Jan 13, 2025

@averikitsch the PR comments have been addressed on #43, so that this PR does not need to wait on resolving them.

@vishwarajanand vishwarajanand mentioned this pull request Jan 13, 2025
Merged
@averikitsch averikitsch merged commit f5e54dd into main Jan 13, 2025
8 checks passed
@averikitsch averikitsch deleted the code-coverage branch January 13, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch averikitsch approved these changes

Assignees

No one assigned

Labels

api: cloudsql-postgres Issues related to the googleapis/llama-index-cloud-sql-pg-python API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vishwarajanand @averikitsch