Feat: implement the processor server by lacroixthomas · Pull Request #4263 · googleforgames/agones

lacroixthomas · 2025-09-02T16:51:01Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:

Implementation of the processor server behind dev feature flag

TODO (some might be on another MR):

New Metrics ? (Other PR)
TLS ? Is it needed ?
Unit tests

Which issue(s) this PR fixes:
Part of #4190

Special notes for your reviewer:
Opening the draft for early feedbacks

github-actions · 2025-09-02T16:51:20Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2025-09-02T16:51:36Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2025-09-02T17:58:28Z

Build Failed 😭

Build Id: 0dfb8b31-e31f-4756-9245-fc6a5ef6c6fe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-09-02T18:44:59Z

/gcbrun

agones-bot · 2025-09-02T20:16:22Z

Build Succeeded 🥳

Build Id: be7478b2-5c1c-498c-8498-6d3e35aaedb5

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-3b0ba99
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-3b0ba99
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-3b0ba99-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-3b0ba99
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-3b0ba99
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-3b0ba99
Linux C++ SDK (build): agonessdk-1.52.0-dev-3b0ba99-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-3b0ba99.zip

A preview of the website (the last 30 builds are retained):

https://3b0ba99-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-3b0ba99

github-actions · 2025-09-04T17:38:43Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

github-actions · 2025-09-04T18:22:26Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2025-09-04T19:26:27Z

Build Failed 😭

Build Id: 91746f34-8ce0-429a-b492-139ab1d0e898

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-09-04T20:26:19Z

/gcbrun

agones-bot · 2025-09-04T22:13:56Z

Build Succeeded 🥳

Build Id: e64c3f64-8657-4721-8904-83a4c840bd47

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-6dec885
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-6dec885
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-6dec885-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-6dec885
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-6dec885
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-6dec885
Linux C++ SDK (build): agonessdk-1.52.0-dev-6dec885-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-6dec885.zip

A preview of the website (the last 30 builds are retained):

https://6dec885-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-6dec885

agones-bot · 2025-09-08T00:22:30Z

Build Succeeded 🥳

Build Id: 1241bbbd-7bde-46ec-95ec-3b8712be910f

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-6351400
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-6351400
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-6351400-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-6351400
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-6351400
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-6351400
Linux C++ SDK (build): agonessdk-1.52.0-dev-6351400-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-6351400.zip

A preview of the website (the last 30 builds are retained):

https://6351400-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-6351400

install/helm/agones/templates/processor.yaml

agones-bot · 2025-10-22T23:01:11Z

Build Failed 😭

Build Id: 97a4c8b6-9fdc-444b-8694-653b14e80797

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-24T22:35:19Z

Build Failed 😭

Build Id: 04dff753-1c63-4882-bb56-0f2ec1158e07

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-25T00:35:28Z

Build Failed 😭

Build Id: 4aa098c0-e599-4386-8bd8-7f51ecf4034f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-11-19T23:48:24Z

Build Failed 😭

Build Id: 0e0967ca-55e6-4012-9f36-c8c00cf9108c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas · 2025-12-03T23:13:57Z

I'll come back to this task in the next days / week, didn't forget about it !

agones-bot · 2025-12-04T00:59:03Z

Build Failed 😭

Build Id: af923d1a-67cc-48c6-9039-634cda0feb28

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-12-18T00:43:34Z

Build Failed 😭

Build Id: 1c732008-568e-45a8-9455-40c393278ecd

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2025-12-20T20:15:31Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2025-12-20T20:22:36Z

Build Failed 😭

Build Id: 792e8178-8cf5-4479-b4f8-1f6dbd845439

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions · 2025-12-20T20:48:22Z

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

agones-bot · 2025-12-29T02:31:26Z

Build Succeeded 🥳

Build Id: ae481ca3-0326-495d-96ef-c576b0b897b1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.55.0-dev-2c56805
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.55.0-dev-2c56805
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.55.0-dev-2c56805-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.55.0-dev-2c56805
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.55.0-dev-2c56805
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.55.0-dev-2c56805
Linux C++ SDK (build): agonessdk-1.55.0-dev-2c56805-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.55.0-dev-2c56805.zip

A preview of the website (the last 30 builds are retained):

https://2c56805-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-2c56805

cmd/processor/handler.go

agones-bot · 2026-01-09T01:17:47Z

Build Succeeded 🥳

Build Id: 251769c1-44a6-4da2-8412-8fb482ce4b35

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.55.0-dev-157d44b
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.55.0-dev-157d44b
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.55.0-dev-157d44b-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.55.0-dev-157d44b
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.55.0-dev-157d44b
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.55.0-dev-157d44b
Linux C++ SDK (build): agonessdk-1.55.0-dev-157d44b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.55.0-dev-157d44b.zip

A preview of the website (the last 30 builds are retained):

https://157d44b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.55.0-dev-157d44b

lacroixthomas · 2026-01-11T00:21:05Z

I'm waiting for the e2e to finish and I'll rollback the feature gate from alpha to dev, it's just to confirm that the e2e still works with the new processor (which seems to be alright now !)

It's still in draft because I want to write some unit tests around the handler.go from the processor server, only added you as reviewers, if you want to have a look before the unit tests are done 😄

I'm gonna create an other PR to add new metrics

agones-bot · 2026-01-11T02:05:40Z

Build Failed 😭

Build Id: 27499b51-b73c-4d32-88b4-125e998dc67b

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2026-01-16T22:09:38Z

Build Succeeded 🥳

Build Id: a47da26c-d7ac-49b4-b2b6-9d931adfffd7

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-19ec0a4
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-19ec0a4
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-19ec0a4-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-19ec0a4
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-19ec0a4
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-19ec0a4
Linux C++ SDK (build): agonessdk-1.56.0-dev-19ec0a4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.56.0-dev-19ec0a4.zip

A preview of the website (the last 30 builds are retained):

https://19ec0a4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-19ec0a4

lacroixthomas · 2026-01-28T22:40:53Z

Note: Ensure that this issue is also part of this new design: #4415
About a request context cancelled, to not add it to the list to process or ensuring it wont be processed - more info on the issue

agones-bot · 2026-02-06T00:58:56Z

Build Failed 😭

Build Id: b641d47d-5fda-403b-b3be-7a82fb901854

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

github-actions bot added kind/feature New features for Agones size/XL labels Sep 2, 2025

github-actions bot added the size/L label Sep 7, 2025

lacroixthomas force-pushed the features/implement-processor-server branch from 6351400 to c239fdb Compare October 22, 2025 21:02

lacroixthomas commented Oct 22, 2025

View reviewed changes

install/helm/agones/templates/processor.yaml Outdated Show resolved Hide resolved

lacroixthomas force-pushed the features/implement-processor-server branch from 56cf40e to de22bdc Compare November 19, 2025 22:36

lacroixthomas force-pushed the features/implement-processor-server branch from de22bdc to 3078f81 Compare December 3, 2025 23:31

lacroixthomas force-pushed the features/implement-processor-server branch from 3078f81 to ddd9a28 Compare December 17, 2025 23:05

lacroixthomas force-pushed the features/implement-processor-server branch from 87c55c4 to 2518c80 Compare December 20, 2025 20:48

lacroixthomas added 12 commits December 28, 2025 20:13

feat: update logs

377caa4

feat: test pipeline with ProcessorAllocator in alpha

2b80e04

feat: test pipeline with ProcessorAllocator in alpha

a8fefd2

feat: debug e2e failing

34ae63a

feat: debug e2e failing

b86c733

feat: fix error handling and feature gate from dep env

bddde87

feat: fix yaml install

70ee775

feat: fix extension and allocator with processor server

30ff042

feat: update unit test

67d7e2a

feat: add missing status

8d7f3b1

feat: fix missing namespace

563c1e5

feat: refactor a bit the error handling

2c56805

lacroixthomas force-pushed the features/implement-processor-server branch from 2ac6bcd to 2c56805 Compare December 29, 2025 01:13

lacroixthomas commented Jan 7, 2026

View reviewed changes

cmd/processor/handler.go Outdated Show resolved Hide resolved

Merge branch 'main' into features/implement-processor-server

157d44b

lacroixthomas added 3 commits January 10, 2026 18:59

feat: minor changes

540e514

feat: rollback unit test fix (other PR)

ee33b49

lacroixthomas requested review from igooch and markmandel January 11, 2026 00:18

Merge branch 'main' into features/implement-processor-server

06f6d9b

Merge branch 'main' into features/implement-processor-server

19ec0a4

Merge branch 'main' into features/implement-processor-server

4bdd4f1

Conversation

lacroixthomas commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

agones-bot commented Sep 2, 2025

Uh oh!

lacroixthomas commented Sep 2, 2025

Uh oh!

agones-bot commented Sep 2, 2025

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

github-actions bot commented Sep 4, 2025

Uh oh!

agones-bot commented Sep 4, 2025

Uh oh!

lacroixthomas commented Sep 4, 2025

Uh oh!

agones-bot commented Sep 4, 2025

Uh oh!

agones-bot commented Sep 8, 2025

Uh oh!

Uh oh!

agones-bot commented Oct 22, 2025

Uh oh!

agones-bot commented Oct 24, 2025

Uh oh!

agones-bot commented Oct 25, 2025

Uh oh!

agones-bot commented Nov 19, 2025

Uh oh!

lacroixthomas commented Dec 3, 2025

Uh oh!

agones-bot commented Dec 4, 2025

Uh oh!

agones-bot commented Dec 18, 2025

Uh oh!

github-actions bot commented Dec 20, 2025

Uh oh!

agones-bot commented Dec 20, 2025

Uh oh!

github-actions bot commented Dec 20, 2025

Uh oh!

agones-bot commented Dec 29, 2025

Uh oh!

Uh oh!

agones-bot commented Jan 9, 2026

Uh oh!

lacroixthomas commented Jan 11, 2026

Uh oh!

agones-bot commented Jan 11, 2026

Uh oh!

agones-bot commented Jan 16, 2026

Uh oh!

lacroixthomas commented Jan 28, 2026

Uh oh!

agones-bot commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lacroixthomas commented Sep 2, 2025 •

edited

Loading