Flaky Test: TestGameServerAllocationReturnLabels

[Sivasankaran25]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #4431

Special notes for your reviewer:

[agones-bot]

Build Succeeded 🥳

Build Id: a765df12-e1ab-4f81-82d0-68838557c782

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-9bd03d6
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-9bd03d6
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-9bd03d6-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-9bd03d6
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-9bd03d6
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-9bd03d6
• Linux C++ SDK (build): agonessdk-1.56.0-dev-9bd03d6-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.56.0-dev-9bd03d6.zip

A preview of the website (the last 30 builds are retained):

• https://9bd03d6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4435/head:pr_4435 && git checkout pr_4435
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-9bd03d6

[agones-bot]

Build Failed 😭

Build Id: 07ca1545-b7cb-4a5c-b16f-477889d0e21a

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 🥳

Build Id: 91fde476-2248-4b2f-93e8-d90926e17378

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.56.0-dev-d3cf825
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.56.0-dev-d3cf825
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.56.0-dev-d3cf825-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.56.0-dev-d3cf825
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.56.0-dev-d3cf825
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.56.0-dev-d3cf825
• Linux C++ SDK (build): agonessdk-1.56.0-dev-d3cf825-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.56.0-dev-d3cf825.zip

A preview of the website (the last 30 builds are retained):

• https://d3cf825-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4435/head:pr_4435 && git checkout pr_4435
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.56.0-dev-d3cf825

[markmandel]

I think this is heading in the right direction, but isn't quite there yet.

[markmandel]

I recently found https://pkg.go.dev/github.com/stretchr/testify@v1.11.1/require#EventuallyWithT - which for more complicated test conditions is definitely a better option for sure.

Then we can maintain the checks for labels and annotations, and have them reported in a way that's easier to read.

[markmandel]

Does this fix the flake where this comes back with an Unallocated state? Should the eventually be wrapping the allocation call?