fix #906 - secondary opening hours must be an array#1024
Open
Osiris-Team wants to merge 1 commit intogooglemaps:mainfrom
Open
fix #906 - secondary opening hours must be an array#1024Osiris-Team wants to merge 1 commit intogooglemaps:mainfrom
Osiris-Team wants to merge 1 commit intogooglemaps:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #906
As shown in the rest api docs here https://developers.google.com/maps/documentation/places/web-service/details?hl=de#Place-secondary_opening_hours secondary_opening_hours should be an array and not a object.
Do not merge this yet, I am waiting/looking for an example json response that contains this field to verify and add a test case.