Skip to content

upgrade to recent peer projects#33

Open
jcable wants to merge 3 commits intogoogleworkspace:mainfrom
jcable:main
Open

upgrade to recent peer projects#33
jcable wants to merge 3 commits intogoogleworkspace:mainfrom
jcable:main

Conversation

@jcable
Copy link

@jcable jcable commented Jan 26, 2026

Just the bare minimum of changes I had to make to avoid Typescript object model clashes with hastscript 9.

@gemini-code-assist
Copy link

Summary of Changes

Hello @jcable, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant dependency upgrade across the project, primarily driven by the need to resolve TypeScript object model clashes with the new hastscript 9. The changes ensure the codebase remains compatible with the latest versions of its dependencies and aligns with modern ECMAScript Modules (ESM) standards through explicit import paths and updated TypeScript configurations. This comprehensive update aims to enhance the project's stability and maintainability by leveraging the latest features and fixes from its ecosystem.

Highlights

  • Dependency Upgrades: Major version bumps for core dependencies like hastscript (from v7 to v9), github-slugger, and hast-util-to-string. Numerous development dependencies, including @googleapis/docs, @typescript-eslint/*, eslint, googleapis, prettier, typescript, unified, and vitest, have also been updated to their latest major versions.
  • ESM Compatibility: The project has been updated for ECMAScript Modules (ESM) compatibility. This includes modifying tsconfig.json to use nodenext for module resolution and module type, and updating all internal import paths across the codebase to explicitly include .js extensions.
  • Test and Snapshot Adjustments: Snapshot files (hast.test.ts.snap, html.test.ts.snap) were updated to reflect minor changes in Vitest's snapshot header and export keys. Additionally, e2e tests in html.test.ts were adjusted to handle prettier.format as an asynchronous operation, making the test functions async.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on upgrading project dependencies, updating module import paths to include .js extensions for ESM compatibility, and adjusting TypeScript configuration (tsconfig.json) to align with these changes. The changes also include minor updates to snapshot tests and making prettier.format calls awaited, indicating a shift to an asynchronous API or better handling of it. These updates are essential for maintaining compatibility with newer versions of peer projects and ensuring the project's continued functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants