Skip to content

[GOVCMS-5033] Support scaffold consolidation#175

Merged
stooit merged 5 commits intodevelopfrom
feature/custom-composer
Oct 6, 2020
Merged

[GOVCMS-5033] Support scaffold consolidation#175
stooit merged 5 commits intodevelopfrom
feature/custom-composer

Conversation

@stooit
Copy link
Collaborator

@stooit stooit commented Oct 5, 2020

Provide a base for extensible SaaS codebases (to support scaffold consolidation effort).

Reduce/remove need for #137 until Satis or similar is available.

@tobybellwood
Copy link

Great work, my 2c - govcms should be implementing drupal scaffolding inheritance from Drupal core, as we do in drupal-example-simple. It's perfect for this use case, and extensible. I'd be happy to give a demo.
Also, I tinkered with composer patchsets as a way of centrally managing patches for a known set of modules - it may be of use (https://github.com/tobybellwood/patchset)

stooit added 2 commits October 6, 2020 12:15
Removed core-recommended.
Removed merge-plugin.
@stooit
Copy link
Collaborator Author

stooit commented Oct 5, 2020

Agreed, unfortunately the change needs to be applied in the distro first (e.g your PR: govCMS/GovCMS8#478) - we can't really move to core-composer-scaffold here as it conflicts with the legacy scaffold.

I have just simplified this PR a bit (and removed legacy scaffold, as it's really not necessary here) so it should make the pathway forward a little easier.

@tobybellwood
Copy link

Yeah, that upstream PR is the unlocker. I've updated a few times for releases. Let me know if it needs any attention

@stooit stooit merged commit 93e1cdb into develop Oct 6, 2020
@stooit stooit deleted the feature/custom-composer branch October 6, 2020 05:24
fubarhouse added a commit that referenced this pull request Oct 21, 2020
* Updated to non-deterministic hash salt. (#170)

* [GOVCMS-5205]: Execute the verify module stage. (#168)

* Execute the verify module stage.

Lint CI yaml.

A little debugging.

TTY.

Update fail early.

New ci image.

Update to cat output.

Change op location.

Update to run only on schedules.

* Update .gitlab-ci.yml

Co-authored-by: Steve <sj.worley88@gmail.com>

Co-authored-by: Stuart Rowlands <1256274+stooit@users.noreply.github.com>

* Changes for release v8.9.6 (#172)

* Added yq/jq binaries for pre-deploy validation scripts. (#173)

* [GOVCMS-5033] Support scaffold consolidation (#175)

* Added extensible composer & patches support.
* Removed legacy drupal-scaffold.
* Removed core-recommended (provided upstream).

* Bump to latest Lagoon version.

* PHP 7.4 (#174)

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>

* [GOVCMS-5033] Flexible image names (#176)

* Support move to govcms/govcms image name.

* Push tweak to support different CLI names.

* Updates for release (#180)

* Updates for release
* Update docker-compose default PHP value.

Co-authored-by: Karl Hepworth <karl.hepworth@gmail.com>
Co-authored-by: Steve <sj.worley88@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants