Consider tier1 formats language feature in RO/RW storage texture test#4567
Consider tier1 formats language feature in RO/RW storage texture test#4567andyleiserson wants to merge 1 commit intogpuweb:mainfrom
Conversation
|
|
||
| const requiredFeature = getRequiredFeatureForTextureFormat(format); | ||
| if (requiredFeature) { | ||
| t.skipIfDeviceDoesNotHaveFeature(requiredFeature); |
There was a problem hiding this comment.
Hm........ in theory, the correct thing to do here would be to check wgslLanguageFeatures and not the device features. Because:
- It's not just the new formats that should be skipped when the browser doesn't have support, it's also the existing formats that were newly-added to WGSL.
- We should be running this test if the browser (compiler) supports the format, even if the device doesn't.
But we didn't add a wgsl language feature! Filed gpuweb/gpuweb#5524
src/webgpu/shader/validation/extension/readonly_and_readwrite_storage_textures.spec.ts
Outdated
Show resolved
Hide resolved
f65299b to
3774f5b
Compare
|
Updated with a check of the new language feature, currently commented out. I'm not sure the best way to proceed here:
Maybe there should be a test specifically for the |
|
We should go ahead and add some tests that fail. We can have separate test that JUST tests that using the Then, with that out of the way, I think we can make this test complete now:
This way it will start running in more places as soon as the wgsl feature is enabled (when the compiler supports the feature but the hardware does not). WDYT, does this sound right? (Also let me know if you want to tackle all of this or not. Thanks!) |
|
Yes, that sounds right to me. I will try to pick this back up and revise the RO/RW test to work as you suggest, plus add a test specifically for the tier1 extension. The |
Changes the
readonly_and_readwrite_storage_texturestest to consider the tier1 formats language feature.Issue: none
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.