docs: Iterate on the OTel Engine Documentation#5404
Conversation
|
💻 Deploy preview deleted (docs: Iterate on the OTel Engine Documentation). |
|
I can't see the new docs in the preview so i've definitely fudged the setup, would need some guidance there for sure @clayton-cornell |
Hmmm... some direct links might help?
There are still a few errors in the markdown draft. Links are broken in at least one place... maybe more. |
clayton-cornell
left a comment
There was a problem hiding this comment.
We still need to follow up and check and xref links to make sure they work :-)
There was a problem hiding this comment.
Pull request overview
This PR iterates on the OpenTelemetry (OTel) Engine documentation for Grafana Alloy by improving structure and usability. It introduces a dedicated introduction page explaining the two engines (Default Engine and OTel Engine), adds a getting started guide with concrete examples, and reorganizes component listings using collapsible sections for better readability.
Changes:
- Introduces a new "Introduction" page (
docs/sources/open-telemetry/_index.md) with high-level explanation of the engines, terminology, and a comprehensive list of included OTel components - Adds a "Getting Started" guide (
docs/sources/open-telemetry/get-started.md) with concrete CLI examples for running the OTel Engine with and without the Alloy Engine extension - Creates a new shared experimental stability content file specific to the OTel Engine (
docs/sources/shared/stability/experimental_otel.md) - Refactors CLI reference documentation to remove duplicate examples and link to the new getting started guide
- Adds parameter definitions for
FULL_OTEL_ENGINE,OTEL_ENGINE, andDEFAULT_ENGINEto support consistent terminology
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/sources/shared/stability/experimental_otel.md | New shared content file for OTel Engine experimental feature disclaimer |
| docs/sources/reference/cli/otel.md | Removed duplicate configuration examples and added link to new getting started guide; improved flag documentation |
| docs/sources/open-telemetry/get-started.md | New getting started guide with CLI examples for both standalone OTel Engine and with Alloy Engine extension |
| docs/sources/open-telemetry/_index.md | New introduction page with terminology, component listings in collapsible sections, and overview of the OTel Engine |
| docs/sources/_index.md.t | Added parameter definitions for engine terminology |
| docs/sources/_index.md | Added parameter definitions for engine terminology |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| You can access the {{< param "DEFAULT_ENGINE" >}} UI and metrics on port `12345`. | ||
|
|
||
| ## Run with {{% param "PRODUCT_NAME" %}} Helm chart | ||
|
|
There was a problem hiding this comment.
@thampiotr a question for you since you're exploring dog fooding. I would like to add a basic helm values snippet here for users, do you happen to have one handy?
Also, I noticed that our most recent helm release 1.5.3 references alloy version 1.12.2 which doesn't yet include the OTel Engine. I assume we'll need to make another release that will reference Alloy 1.13.0 - is this part of the release process already or something we need to do separately?
There was a problem hiding this comment.
I don't currently have helm values for it. I may have some later this week. I think it should be quite easy to test it locally with example/kind which can create you local k8s cluster and you can install Alloy using helm chart there.
Yep, updating helm chart should be part of the release. You can override the Alloy image by setting image or something like that in Helm chart's values.yaml.
There was a problem hiding this comment.
ah! forgot about the image field..makes sense. I have a basic values file to try out so will give that a whirl
thampiotr
left a comment
There was a problem hiding this comment.
This is looking great, short and easy to understand! Some comments, but nothing dramatic.
|
Yup, this iteration added a lot more content and it's looking really good, especially for an Experimental release :-) |
|
I will merge this as is since the documents are hidden anyway, there's one more comment to address about helm charts which i've left as TODO as I actually suspect we might need to make some changes to the helm chart to get that working. This can be addressed in a follow up |
Part of #4722 This addresses a couple points of feedback in the first iteration: * This PR introduces a separate "Introduction" page, which has a high level explanation of the two engines, and outlines the motivation/benefits of the OTel Engine * This main page has a list of components, so far I can't find a way to automate this - but using a dropdown component I feel like the information is more approachable. I've also linked to the OCB manifest just in case folks want to look in more detail * I've included a "Getting Started" page which has concrete examples to get off the ground with the new engine. I've moved the examples away from the CLI docs page to deduplicate --------- Co-authored-by: Clayton Cornell <clayton.cornell@grafana.com> Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Part of #4722
This addresses a couple points of feedback in the first iteration: