Conversation
|
|
| Launch chrome and look for main-view element | ||
| */ | ||
| headers := make(map[string]interface{}) | ||
| if len(cfg.BasicAuth.Username) != 0 && len(cfg.BasicAuth.Password) != 0 { |
There was a problem hiding this comment.
why would anonymous login require authentication?
There was a problem hiding this comment.
the anonymous login is for Grafana, meaning that the grafana dashboard (app) itself doesn't require authentication (user account) but it still might be hidden behind a reverse proxy that requires HTTP-Basic auth.
So I see them as two separate authentication requirements.
| time.Sleep(2000 * time.Millisecond) | ||
|
|
||
| headers := make(map[string]interface{}) | ||
| if len(cfg.BasicAuth.Username) != 0 && len(cfg.BasicAuth.Password) != 0 { |
There was a problem hiding this comment.
same for this file, this is for aws login, and doesn't use basic auth, maybe this was not intended?
There was a problem hiding this comment.
see the following comment #144 (comment)
but if u think it's not needed then I'll just remove it.
|
|
||
| // chromedp.WaitVisible(`//*[@href="login/grafana_com"]/i`, chromedp.BySearch), | ||
|
|
||
| headers := make(map[string]interface{}) |
There was a problem hiding this comment.
same for this file, this is for gcom (grafana cloud) login, and doesn't use basic auth, maybe this was not intended?
There was a problem hiding this comment.
see the following comment #144 (comment)
but if u think it's not needed then I'll just remove it.
| time.Sleep(time.Duration(cfg.General.PageLoadDelayMS) * time.Millisecond) | ||
|
|
||
| headers := make(map[string]interface{}) | ||
| if len(cfg.BasicAuth.Username) != 0 && len(cfg.BasicAuth.Password) != 0 { |
There was a problem hiding this comment.
same for this file, this is for local login (via ui interaction), and doesn't use basic auth, maybe this was not intended?
There was a problem hiding this comment.
see the following comment #144 (comment)
but if u think it's not needed then I'll just remove it.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
3 participants
No description provided.