Fix Prettier Lint Issues and Issues with Faro Initialization#211
Merged
SeamusGrafana merged 5 commits intomainfrom May 16, 2025
Merged
Fix Prettier Lint Issues and Issues with Faro Initialization#211SeamusGrafana merged 5 commits intomainfrom
SeamusGrafana merged 5 commits intomainfrom
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
federicotdn
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues form previous PRs that are merged;
This fixes a couple of minor issues reported by
prettierin the CI build.See: https://github.com/grafana/quickpizza/actions/runs/15067140875/job/42354426438
It also fixes another issue found in testing here (and caused by #205), where if Faro is not initialized, the page fails to show any recommendations, or allows pages to be used, because its calling something that is undefined. Its a bit of an edge case as if the App is Instrumented with Faro, it expects a URL to be given, but here its an optional value.
So, to workaround this, if no Faro URL is provided, we still initialize Faro, but it does not have a URL defines, allowing the
faroobject to be accessible and used, without causing issues.