Skip to content

Fix Prettier Lint Issues and Issues with Faro Initialization#211

Merged
SeamusGrafana merged 5 commits intomainfrom
fix/eslint-prettier-issues
May 16, 2025
Merged

Fix Prettier Lint Issues and Issues with Faro Initialization#211
SeamusGrafana merged 5 commits intomainfrom
fix/eslint-prettier-issues

Conversation

@SeamusGrafana
Copy link
Contributor

@SeamusGrafana SeamusGrafana commented May 16, 2025

This PR fixes two issues form previous PRs that are merged;


This fixes a couple of minor issues reported by prettier in the CI build.

See: https://github.com/grafana/quickpizza/actions/runs/15067140875/job/42354426438


It also fixes another issue found in testing here (and caused by #205), where if Faro is not initialized, the page fails to show any recommendations, or allows pages to be used, because its calling something that is undefined. Its a bit of an edge case as if the App is Instrumented with Faro, it expects a URL to be given, but here its an optional value.

So, to workaround this, if no Faro URL is provided, we still initialize Faro, but it does not have a URL defines, allowing the faro object to be accessible and used, without causing issues.

@SeamusGrafana SeamusGrafana requested a review from a team as a code owner May 16, 2025 11:25
@SeamusGrafana SeamusGrafana self-assigned this May 16, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@SeamusGrafana SeamusGrafana changed the title Fix Prettier Lint Issues Fix Prettier Lint Issues and Issues with Faro Initialization May 16, 2025
@SeamusGrafana SeamusGrafana marked this pull request as draft May 16, 2025 12:46
@SeamusGrafana SeamusGrafana marked this pull request as ready for review May 16, 2025 13:02
@SeamusGrafana SeamusGrafana merged commit 96f80d3 into main May 16, 2025
6 checks passed
@SeamusGrafana SeamusGrafana deleted the fix/eslint-prettier-issues branch May 16, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants