fix: safely call Faro via window optional chaining#390
Merged
Conversation
`faro.api.` -> `window.faro?.api?.`
MattIPv4
force-pushed
the
MattIPv4/safe-faro-calls
branch
from
6396eff to
99cece6
Compare
ankur22
approved these changes
Feb 9, 2026
federicotdn
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If Faro fails to load, or JS logic runs before Faro has finished loading,
faroand/orfaro.apimay be undefined, causing pages to not work as expected. This was seen in grafana/synthetic-monitoring-app#1580, where test scripts were attempting to submit the login form before Faro was loaded, causing the JS to error and fail. I've switched all Faro usages fromfaro.api.towindow.faro?.api?., which should handle bothwindow.farobeing undefined (before Faro has loaded) andwindow.faro.apibeing defined (before Faro has initialized).