Skip to content

Comments

feat: migrate to plugin-ci-workflows#1522

Merged
VikaCep merged 9 commits intomainfrom
feat/migrate-ci-workflow
Jan 20, 2026
Merged

feat: migrate to plugin-ci-workflows#1522
VikaCep merged 9 commits intomainfrom
feat/migrate-ci-workflow

Conversation

@VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Dec 17, 2025

Migrate to plugin-ci-workflows shared workflows

Closes #1235

Overview

Migrates our custom GitHub Actions CI/CD workflows to Grafana's standardized shared workflows from plugin-ci-workflows, following the provisioned-plugin-auto-cd pattern.

This migration enables:

  • Argo CD-based deployments (replacing manual deployment-tools PRs)
  • Alignment with Grafana plugins platform best practices
  • Reduced maintenance burden (leveraging shared, battle-tested workflows)
  • All existing functionality preserved

Changes

New Workflows

.github/workflows/push.yml (replaces on-pr-creation.yml + on-push-to-main.yml)

  • On PRs: Runs CI (lint, test, build, typecheck) + custom validations
  • On push to main: Runs CI + auto-deploys to dev via Argo CD + Release Please + TechDocs + bundle size tracking

.github/workflows/publish.yml (replaces dispatch_deploy-plugin.yml)

  • Manual deployments to dev/ops/prod
  • Can deploy any branch (including PRs) to dev for testing
  • Supports docs-only deployments

Notes

After merging, we need to:

  • Verify manual deployment to ops/prod
  • Remove DangerJS fallback

⚠️ Tests performance
Tests now run without sharding, increasing CI duration, because the shared actions don't support it. This is an intentional trade-off for standardization and reduced maintenance. We can optimize test performance independently or work with the platform team to add sharding support if needed.

Requires https://github.com/grafana/deployment_tools/pull/436303

@VikaCep VikaCep self-assigned this Dec 17, 2025
@github-actions github-actions bot added chore A miscellaneous change added to the application. feature A feature added to the application. labels Dec 17, 2025
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Script size changes

Name +/- Main This PR Outcome
[767.js] = 1,717.17 kB 1,717.17 kB
[962.js] = 976.83 kB 976.83 kB
[datasource/module.js] = 24.53 kB 24.53 kB
[692.js] = 20.57 kB 20.57 kB
[663.js] = 5.84 kB 5.84 kB
[module.js] = 4.92 kB 4.92 kB

Totals

Name +/- Main This PR Outcome
[Scripts] = 2,749.87 kB 2,749.87 kB
[Non-script Assets] = 2,668.53 kB 2,668.53 kB
[All] = 5,418.40 kB 5,418.40 kB

Generated by 🚫 dangerJS against c3c387b

@VikaCep
Copy link
Contributor Author

VikaCep commented Dec 18, 2025

Verified deploying to dev works successfully:

image
  • Version working in dev
image

@VikaCep VikaCep marked this pull request as ready for review December 18, 2025 19:51
@VikaCep VikaCep requested a review from a team as a code owner December 18, 2025 19:51
@VikaCep VikaCep requested review from ckbedwell and removed request for a team December 18, 2025 19:51
@VikaCep VikaCep requested a review from w1kman January 9, 2026 14:05
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👏

@VikaCep VikaCep merged commit b92db08 into main Jan 20, 2026
35 of 36 checks passed
@VikaCep VikaCep deleted the feat/migrate-ci-workflow branch January 20, 2026 13:52
@VikaCep
Copy link
Contributor Author

VikaCep commented Jan 20, 2026

Note: needed to remove some old vault configs from deployment_tools otherwise the Argo workflow would fail randomly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore A miscellaneous change added to the application. feature A feature added to the application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate CI/CD to shared plugin-ci-workflows

3 participants