fix: align channel data structure with backend API specification#1543
Merged
fix: align channel data structure with backend API specification#1543
Conversation
Script size changes
Totals
|
d2420ad to
1e8475e
Compare
ckbedwell
previously approved these changes
Jan 22, 2026
Contributor
ckbedwell
left a comment
There was a problem hiding this comment.
LGTM! I much prefer this to the previous schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns the frontend's k6 channel data structure with the new backend API specification. The channel information is now stored at the root level (
channels.k6) instead of nested within check type settings. See https://github.com/grafana/synthetic-monitoring/issues/408#issuecomment-3595507029 for its definition and discussion.Backend Context
The backend API now expects/returns channel data in this format:
Request (create/update check):
Response (fetching checks):
Related backend PR: https://github.com/grafana/synthetic-monitoring-api/pull/1876