Merged
Conversation
github-actions
bot
added
the
chore
VikaCep
force-pushed
the
chore/migrate-react-router-v7
branch
from
831262c to
478602e
Compare
VikaCep
changed the title
- Upgrade react-router-dom@6.27.0 to react-router@7.13.0 - Update all imports from 'react-router-dom' to 'react-router' - Fix Navigate components to use absolute paths via getRoute() to prevent infinite redirect loops (v7 resolves relative paths differently than v6) - Add navigation guard in test mock to prevent same-location navigation loops
VikaCep
force-pushed
the
chore/migrate-react-router-v7
branch
from
478602e to
8fc1fee
Compare
|
TruffleHog Scan Results No secrets detected in this PR. |
Script size changes
Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate react router v7
Summary
This PR migrates from React Router v6 to v7, building on top of the v6 migration branch (
chore/migrate-react-router-v6).React Router v7 is largely backward compatible with v6, with the main change being the package consolidation from
react-router-domtoreact-router.Changes
react-router-dom@6.27.0→react-router@7.13.0'react-router-dom'to'react-router'<Navigate>components to use absolute paths viagetRoute()to prevent infinite redirect loops (v7 resolves relative paths differently than v6)Notes
It's not required to perform this migration just yet, but given that v7 is the actively maintained version with no breaking API changes, and other Grafana plugins (like logs-drilldown) have already adopted it, upgrading now is a low-risk way to stay aligned with the ecosystem and avoid future technical debt.