fix: normalize empty alertSensitivity from API to none#1586
Merged
Conversation
Script size changes
Totals
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1585
Problem
Checks created directly via the API (e.g. through Terraform or custom integrations) may leave the
alertSensitivityfield as an empty string rather than explicitly setting it to"none". The API accepts and handles this correctly, but the app does not.When the app encounters a check with an empty
alertSensitivity, it misinterprets it as a set value, causing two user-facing issues:Solution
Normalize empty
alertSensitivityvalues to"none"at the data source layer when checks are fetched from the API. This is done in thelistChecksmethod, which is the single entry point for all check data in the app.