Skip to content

Comments

fix: normalize empty alertSensitivity from API to none#1586

Merged
VikaCep merged 1 commit intomainfrom
fix/alerts-sensitivity-default-value
Feb 11, 2026
Merged

fix: normalize empty alertSensitivity from API to none#1586
VikaCep merged 1 commit intomainfrom
fix/alerts-sensitivity-default-value

Conversation

@VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Feb 11, 2026

Closes #1585

Problem

Checks created directly via the API (e.g. through Terraform or custom integrations) may leave the alertSensitivity field as an empty string rather than explicitly setting it to "none". The API accepts and handles this correctly, but the app does not.

When the app encounters a check with an empty alertSensitivity, it misinterprets it as a set value, causing two user-facing issues:

  1. An incorrect "Alert configuration" warning is shown on the check, stating it has an alert sensitivity but no associated alerting rules could be found.
  2. The alert sensitivity dropdown is disabled on the check edit form, preventing the user from changing the value or making any modifications to the check.

Solution

Normalize empty alertSensitivity values to "none" at the data source layer when checks are fetched from the API. This is done in the listChecks method, which is the single entry point for all check data in the app.

@VikaCep VikaCep self-assigned this Feb 11, 2026
@github-actions github-actions bot added the fix A fix applied to the application. label Feb 11, 2026
@github-actions
Copy link

Script size changes

Name +/- Main This PR Outcome
[411.js] = 2,178.85 kB 2,178.85 kB
[854.js] = 801.09 kB 801.09 kB
[datasource/module.js] +0.66% 25.01 kB 25.18 kB
[692.js] = 20.64 kB 20.64 kB
[663.js] = 5.83 kB 5.83 kB
[module.js] = 4.54 kB 4.54 kB
[156.js] = 1.90 kB 1.90 kB

Totals

Name +/- Main This PR Outcome
[Scripts] = 3,037.85 kB 3,038.02 kB
[Non-script Assets] = 2,677.50 kB 2,677.50 kB
[All] = 5,715.35 kB 5,715.52 kB

Generated by 🚫 dangerJS against cc74b0c

@VikaCep VikaCep marked this pull request as ready for review February 11, 2026 15:28
@VikaCep VikaCep requested a review from a team as a code owner February 11, 2026 15:28
@VikaCep VikaCep requested review from ckbedwell, g3john and w1kman and removed request for a team February 11, 2026 15:28
Copy link
Contributor

@g3john g3john left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VikaCep VikaCep merged commit ef5c1df into main Feb 11, 2026
35 of 36 checks passed
@VikaCep VikaCep deleted the fix/alerts-sensitivity-default-value branch February 11, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix A fix applied to the application.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mishandle of unset check alert sensitivity field

2 participants